Bump API to latest, filter out service IP pools from list fetches - #3316
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fakemonster
approved these changes
Aug 10, 2026
|
|
||
| const { data: allPools } = useQuery( | ||
| q(api.systemIpPoolList, { query: { limit: ALL_ISH } }) | ||
| q(api.systemIpPoolList, { query: { assignment: 'silos', limit: ALL_ISH } }) |
Contributor
There was a problem hiding this comment.
not relevant here, but noting while we're on the subject that we're querying ip pools twice on this page
Collaborator
Author
There was a problem hiding this comment.
Yep, unfortunately this is how we have to do it to give the quick actions menu the full list while also letting the table fetch its single page. It's especially silly on lists that are expected to be short, like this one, where the two fetches are almost certainly going to give you the same results. There are a few ways we could try to avoid it, but I don't think it's worth it.
bnaecker
approved these changes
Aug 10, 2026
david-crespo
enabled auto-merge (squash)
August 10, 2026 19:28
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 10, 2026
oxidecomputer/console@398e00c...abbe25e * [abbe25e8](oxidecomputer/console@abbe25e8) oxidecomputer/console#3316 * [89ea0da9](oxidecomputer/console@89ea0da9) oxidecomputer/console#3315 * [c948e19b](oxidecomputer/console@c948e19b) oxidecomputer/console#3306 * [f2674c54](oxidecomputer/console@f2674c54) oxidecomputer/console#3307 * [aa0b3a03](oxidecomputer/console@aa0b3a03) oxidecomputer/console#3309 * [b60b72bf](oxidecomputer/console@b60b72bf) oxidecomputer/console#3305 * [1b740d37](oxidecomputer/console@1b740d37) oxidecomputer/console#3297 * [4d83dc29](oxidecomputer/console@4d83dc29) oxidecomputer/console#3296 * [967d26ef](oxidecomputer/console@967d26ef) oxidecomputer/console#3294 * [7225d336](oxidecomputer/console@7225d336) oxidecomputer/console#3289 * [826b8fd9](oxidecomputer/console@826b8fd9) oxidecomputer/console#3290 * [10945dcd](oxidecomputer/console@10945dcd) oxidecomputer/console#3292 * [bea24972](oxidecomputer/console@bea24972) oxidecomputer/console#3277 * [a0d28a11](oxidecomputer/console@a0d28a11) oxidecomputer/console#3286
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirmed on dogfood that the filtering works, the two service pools get filtered out.